Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debugbar styles printing #5100

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

paulbalandan
Copy link
Member

Description
Fixes #5097

The truncated styles would actually not pose a problem because in toolbarloader.js.php the styles and scripts from toolbarContainer is dynamically copied to the style and script in the head. After dynamically copying, those should be supposedly removed from toolbarContainer thru responseText.substr. This works well until the last copying of the last style where the removal was "misdirected".

To check that those styles would be redundant if we let it stay is to see that the timeline bars still got styled (in orange bars of varying lengths). Right-clicking on 'Inspect element' you would be that those bars have the class .debug-bar-timeline-** styles with the definition at the bottom.

If any of @rramsey or @kenjis can test this ?

Checklist:

  • Securely signed commits

@kenjis
Copy link
Member

kenjis commented Sep 17, 2021

<style type="text/css">.debu</style> is gone. It is okay.

Screenshot 2021-09-17 17 43 30

@kenjis
Copy link
Member

kenjis commented Sep 18, 2021

@paulbalandan
By the way, your one commit includes more than one change (intent).
In this commit,

  • documentation (comment) removal
  • refactoring (coding style, variable name change, etc)
  • bug fix

In fact, I couldn't figure out what was a real bug fix at first.
If the commit is separated, we could get the intention of code changes,
and our review would be more easily.

system/Debug/Toolbar.php Outdated Show resolved Hide resolved
system/Debug/Toolbar/Views/toolbar.tpl.php Outdated Show resolved Hide resolved
@kenjis
Copy link
Member

kenjis commented Oct 1, 2021

Okay. No <style type="text/css">.debu</style>.
Screenshot 2021-10-01 17 18 07

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulbalandan paulbalandan merged commit dd5c931 into codeigniter4:develop Oct 2, 2021
@paulbalandan paulbalandan deleted the debugbar branch October 2, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible debug toolbar css problem
3 participants