Fix key casting in form_dropdown helper. #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
approved these changes
Aug 29, 2021
samsonasik
approved these changes
Aug 31, 2021
kenjis
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4993.
Description
This fixes the missing string casting for
$optgroupKeyin theform_dropdownhelper.This is an issue since strict
in_arraywas introduced in #3565. Also adds a test for the casting (not pretty, but working).I pointed this at develop as it is supposed to be a bugfix. Please correct if thats wrong 😄
Checklist: