Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CITestStreamFilter compatible with php_user_filter #5014

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Make CITestStreamFilter compatible with php_user_filter #5014

merged 1 commit into from
Aug 20, 2021

Conversation

paulbalandan
Copy link
Member

Description
Related to #4883

During inheritance of php_user_filter: Uncaught ErrorException: Return type of CodeIgniter\Test\Filters\CITestStreamFilter::filter($in, $out, &$consumed, $closing) should either be compatible with php_user_filter::filter($in, $out, &$consumed, bool $closing): int, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Checklist:

  • Securely signed commits

@paulbalandan paulbalandan merged commit 9b4fbce into codeigniter4:develop Aug 20, 2021
@paulbalandan paulbalandan deleted the php-user-filter branch August 20, 2021 12:58
@paulbalandan paulbalandan mentioned this pull request Aug 23, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @MGatner