Additional File functions #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
May 21, 2021
paulbalandan
requested changes
May 21, 2021
| */ | ||
| function same_file(string $file1, string $file2): bool | ||
| { | ||
| return is_file($file1) && is_file($file2) && md5_file($file1) === md5_file($file2); |
There was a problem hiding this comment.
That seems like an unnecessary measure since there are no cryptography concerns here and we already know the string lengths will match. How does this improve on ===?
paulbalandan
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a couple more functions to the
filesystem_helper:directoy_mirror()(from @paulbalandan'sComposerScripts PR) assamefile()`.Checklist: