Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Psr\Cache #4688

Merged
merged 1 commit into from
May 15, 2021
Merged

Remove Psr\Cache #4688

merged 1 commit into from
May 15, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented May 15, 2021

Description
Per the previous discussion, this removes Psr\Cache so it can be created as a separate module. I've started work on this module (https://github.com/MGatner/cache) - we will need to decide where it lives. I lean towards https://github.com/codeigniter4 since it is explicitly an add-on component that should be in the same namespace, but I could also see arguments for https://github.com/codeigniter4projects

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

I'm all for the main codeigniter4 group myself.

@MGatner
Copy link
Member Author

MGatner commented May 15, 2021

Test failure is due to the inevitable code coverage reduction.

@MGatner MGatner merged commit a4c88d3 into codeigniter4:develop May 15, 2021
@MGatner MGatner deleted the strip-psr branch May 15, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants