Update 'updated_at' when enabled in replace() #4684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
replace-timestamps
branch
3 times, most recently
from
b597d75 to
05b79ca
Compare
|
What's happening with this? Why are we all failing at this issue... 🤦♂️ |
|
The Postgre builder actually has a bug which I discovered that testMode will make replace still execute the SQL. For Sqlsrv, I am not sure where went wrong. I am still to setup sql server locally so I can see this thru xdebug. |
paulbalandan
force-pushed
the
replace-timestamps
branch
from
05b79ca to
e6b10da
Compare
|
😭 |
paulbalandan
force-pushed
the
replace-timestamps
branch
from
e6b10da to
a8e6ab1
Compare
MGatner
approved these changes
Jun 5, 2021
sfadschm
reviewed
Jun 5, 2021
You mean the validation part? I think so because replace is like update, isn't it? Why do you think it's not needed anymore? |
sfadschm
reviewed
Jun 6, 2021
paulbalandan
force-pushed
the
replace-timestamps
branch
from
a8e6ab1 to
19e92c1
Compare
MGatner
approved these changes
Jun 8, 2021
paulbalandan
force-pushed
the
replace-timestamps
branch
from
19e92c1 to
69702f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4624
Supersedes and closes #4662
Checklist: