Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Log code #4631

Merged
merged 1 commit into from
May 1, 2021
Merged

Patch Log code #4631

merged 1 commit into from
May 1, 2021

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented May 1, 2021

Description
The Psr\Log code in ThirdParty is a few versions old. This PR updates to the latest code from the PSR repo.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@iRedds
Copy link
Collaborator

iRedds commented May 1, 2021

I have a question.
Why not move this in the composer dependency?

@MGatner
Copy link
Member Author

MGatner commented May 1, 2021

It is already in the Composer dependency, and that version will be used by Composer installations. For download users though they will access this pre-injected version, which requires occasional updates.

@paulbalandan
Copy link
Member

I believe though this should be handled by ComposerScripts.

@MGatner
Copy link
Member Author

MGatner commented May 1, 2021

I think those are only for Kint and Escaper. My guess is that Log has barely changed in many years so didn't seem to need updates. These changes are really just docblock tweaks.

@paulbalandan paulbalandan merged commit 9896c24 into codeigniter4:develop May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants