Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service methods …$params type #4594

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Fix service methods …$params type #4594

merged 1 commit into from
Apr 21, 2021

Conversation

najdanovicivan
Copy link
Contributor

Description
PHPDoc fix for service() and single_service() methods

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct type. Probably someone got confused about the unpacking operator and used array in error.

@paulbalandan paulbalandan merged commit 449245c into codeigniter4:develop Apr 21, 2021
@najdanovicivan najdanovicivan deleted the fix-service branch May 17, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@najdanovicivan @MGatner @paulbalandan