Fix #4579 Missing classname information on output during migrate:rollback #4584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix codeigniter4#4579 Class information on output is missing during migrate:rollback command system\Database\MigrationRunner.php Used the same logic of addHistory to revert on removeHistory Now all classes are printed on command results
|
This looks good! I think that's the right change. Do you feel up to adding a test case for this? It should go in tests/system/Database/Migrations/MigrationRunnerTest.php and verify the CLI messages after one of the removal commands. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4579 Class information on output is missing during migrate:rollback command
Description
At system\Database\MigrationRunner.php
Changed removeHistory at line 774 using the same logic of addHistory to access the $history->class information, so I've been revoved getMigrationName method.
As far as I could see, getMigrationName method was just erasing the information with array_shift function (there was no "_" to work on)
After changing, all rollback passed to show all information correctly.
Now all classes are printed on command results
Checklist: