Change Entity Namespace #4577
Merged
Change Entity Namespace #4577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulbalandan i'm done here, would you like to review this? |
|
What is the benefit of new namespace? next we need to move "Model" classes to Model namespace? The current usage is easier to access (no need deep namespace extends) for mostly db based apps. |
|
The benefit is not about the namespace, it's about organize system directories/sub-directories |
paulbalandan
approved these changes
Apr 17, 2021
|
I'm done here. I would like @MGatner to take final look. |
MGatner
reviewed
Apr 18, 2021
system/Entity.php
Outdated
| } | ||
| $this->_cast = $cast; | ||
| return $this; | ||
| parent::__construct($data); |
There was a problem hiding this comment.
Nothing,, removed :D
mostafakhudair
force-pushed
the
entity-namespace
branch
from
4db0ffc to
d1d6a5b
Compare
MGatner
approved these changes
Apr 19, 2021
|
should i add Services::entity() in a separated PR? or push it in this PR? or we shouldn't added it anyway? |
|
Let's hold off on a service for now. I'd like some resolution to our interface discussion before we start adding more services for classes that don't use interfaces. |
MGatner
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Entity class namespace
Refactor Entity casts