Prefix calls to getenv() during config resolution #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before I change the tests, I just want to confirm if my proposed changes are acceptable, @MGatner , @samsonasik ? |
samsonasik
approved these changes
Apr 12, 2021
|
Yes looks good to me. |
paulbalandan
force-pushed
the
paulbalandan-baseconfig-cookie-path
branch
from
266401c to
df209c9
Compare
|
It's a little hard to see what actually changed in the tests because there are a lot of (good) adjustments, but this looks right to me overall if you feel good about it. |
paulbalandan
force-pushed
the
paulbalandan-baseconfig-cookie-path
branch
from
df209c9 to
60ab7e6
Compare
paulbalandan
force-pushed
the
paulbalandan-baseconfig-cookie-path
branch
from
60ab7e6 to
6c90cab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4559
Closes #4556
Checklist: