Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for strict types #4548

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Apr 10, 2021

Description
Fixes #4408
Fixes #4412

Checklist:

  • Securely signed commits

system/View/Parser.php Outdated Show resolved Hide resolved
Comment on lines +306 to +307
* @var IncomingRequest $request
* @var Response $response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate that we have to do this, but I guess until we get the interfaces discussion resolved this is the best we can do.

@paulbalandan paulbalandan merged commit b967d9e into codeigniter4:develop Apr 23, 2021
@paulbalandan paulbalandan deleted the strict-types branch April 23, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser content typehint [strict_types=1] Toolbar::setFiles() requires int [strict_types=1]
2 participants