-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: filter_var usage #4390
Merged
paulbalandan
merged 2 commits into
codeigniter4:develop
from
iRedds:fix/filter_var-usage
Mar 10, 2021
Merged
Fix: filter_var usage #4390
paulbalandan
merged 2 commits into
codeigniter4:develop
from
iRedds:fix/filter_var-usage
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafakhudair
approved these changes
Mar 5, 2021
iRedds
commented
Mar 5, 2021
iRedds
commented
Mar 5, 2021
Please rebase. |
@paulbalandan Looks like I did something wrong. |
I'm not sure how to fix this but I guess you need to cherry pick your PR commit |
just run this @iRedds
then run FYI: I have test with your branch |
I think I did it. |
paulbalandan
reviewed
Mar 9, 2021
paulbalandan
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the flag parameter in the filter_var function, the default value was incorrectly passed.
By default, null is passed, but an array or integer is expected.
Soft type casting may mask future problems.
Changes:
Checklist: