Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3319 add multibyte support on DOMParser::see() #3324

Merged
merged 6 commits into from
Jul 16, 2020
Merged

Fixes #3319 add multibyte support on DOMParser::see() #3324

merged 6 commits into from
Jul 16, 2020

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 15, 2020 •
edited
Loading

Fixes #3319

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage

@samsonasik samsonasik mentioned this pull request Jul 15, 2020
Closed
@samsonasik
Copy link
Member Author

Hellö Wörld seems converted to Hellö Wörld in DOMParser::see() in call $this->dom->saveHTML() which make it still not work...

@samsonasik
Copy link
Member Author

I applied ensure pass $this->dom->documentElement on dom->saveHTML(), added unit test for it.

@samsonasik samsonasik changed the title Fixes #3319 add multibyte support on Domparser::see() Fixes #3319 add multibyte support on DOMParser::see() Jul 16, 2020
@samsonasik
Copy link
Member Author

travis build green 🎉

@lonnieezell lonnieezell merged commit 1ebffe7 into codeigniter4:develop Jul 16, 2020
@samsonasik samsonasik deleted the support-multibyte-search-on-domparser-see branch July 16, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

See method in controller testing does not recognize accents
2 participants
@samsonasik @lonnieezell