Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci skip] documentation : response->download() require getBody() to be called after send() to force download #3312

Closed
wants to merge 1 commit into from
Closed

[ci skip] documentation : response->download() require getBody() to be called after send() to force download #3312

wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 15, 2020 •
edited
Loading

Tried in controller, without getBody() call after send, it will only shows the file content, not force download.

Checklist:

  • Securely signed commits
  • User guide updated

Without getBody() call after send():

Screen Shot 2020-07-15 at 5 29 11 PM

With getBody() call after send():

Screen Shot 2020-07-15 at 5 26 36 PM

@samsonasik samsonasik mentioned this pull request Jul 15, 2020
Closed
1 task
@samsonasik
Copy link
Member Author

I create alternative PR for it at #3313 which update the code.

@michalsn michalsn mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik