Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more test Files\File class #3232

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

samsonasik
Copy link
Member

more test Files\File class, for getSizeByUnit('b').

For function_exists('finfo_open') check in getMimeType() function. I added @codeCoverageIgnoreStart and @codeCoverageIgnoreEnd as will not never hit in tests.

By this, the Files\File class will have 100% test coverage.

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage

@MGatner MGatner merged commit 06c3ad8 into codeigniter4:develop Jul 6, 2020
@samsonasik samsonasik deleted the more-test-file branch July 6, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants