Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit 'PHP_EOL' in wordwrap #3179

Merged
merged 1 commit into from
Jun 28, 2020
Merged

Use explicit 'PHP_EOL' in wordwrap #3179

merged 1 commit into from
Jun 28, 2020

Conversation

paulbalandan
Copy link
Member

Description
Running CLITest on Windows will likely fail on the testWrap method giving this error message:

image

Upon investigation, this was because CLI::wrap uses the wordwrap function and sets the third parameter into its default value of \n instead of the platform-specific PHP_EOL. This PR adds that.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn merged commit d4d7fdf into codeigniter4:develop Jun 28, 2020
@michalsn
Copy link
Member

Thanks!

@paulbalandan paulbalandan deleted the cli-wrap branch July 4, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants