Fix to ImageMagickHandler #3104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Saving an image back to the same location with a lower quality would result in a failure attempting to copy. -Saving an image to a new spot with a lower quality would result in the image not having a new quality set.
colethorsen
force-pushed
the
feature/imagemagick
branch
from
4c7a2ea to
ffa64c8
Compare
michalsn
reviewed
Jun 16, 2020
| { | ||
| // we're moving it to the same spot so don't do anything. | ||
| if($target === null) |
There was a problem hiding this comment.
I can't see the scenario when this condition would be used.
There was a problem hiding this comment.
This would fail for instance if someone set it to save to the same location and set a quality to 100. I'd think it would be easier for this to just leave it alone, than to fail trying to copy it to the same spot
There was a problem hiding this comment.
I understand but look at line 289. $target will never be a null value.
|
Fixed via #3268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Saving an image back to the same location with a lower quality would result in a failure attempting to copy.
-Saving an image to a new spot with a lower quality would result in the image not having a new quality set.
Each pull request should address a single issue and have a meaningful title.
Description
Explain what you have changed, and why.
Checklist: