Fix. router no set, Redirect can't work #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
May 29, 2020
| @@ -970,10 +970,11 @@ public function testAddRedirect() | |||
| { | |||
| $routes = $this->getCollector(); | |||
|
|
|||
| $routes->addRedirect('users', 'Users::index', 307); | |||
| //The second parameter is either the new URI to redirect to, or the name of a named route. | |||
| $routes->addRedirect('users', 'users/index', 307); | |||
There was a problem hiding this comment.
I think instead of modify existing test, it needs new tests for new allowed usage?
There was a problem hiding this comment.
This not a new allowed usage. The test is a mistak,It should not use Class::method.This is not what we accept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix. #3041
Checklist: