Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New features for pagination #2899

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

jlamim
Copy link
Contributor

@jlamim jlamim commented Apr 28, 2020

Description
The new features comprise a set of methods that will allow the user to build a pagination structure following the traditional way, where "next" and "prev" advance or return to a page and not to a group of pagination links as is the default.

Added methods:

  • hasPreviousPage: checks if there is a page before the current page
  • getPreviousPage: retrieves the URI of the page prior to the current page
  • hasNextPage: checks if there is a page after the current page
  • getNextPage: retrieves the page's URI after the current page

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Looks good. Thanks!

It does need new tests added for the new methods and something added to the docs about this.

@jlamim
Copy link
Contributor Author

jlamim commented Apr 28, 2020

@lonnieezell I'm already working on testing and updating the documentation. Soon I will give the commits.

@lonnieezell
Copy link
Member

Looks good @jlamim Thanks for tackling this!

@lonnieezell lonnieezell merged commit 1b099a7 into codeigniter4:develop Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants