Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability in the userguide with a fixed size #2846

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

jreklund
Copy link
Contributor

  • I have now made the userguide fixed to 900px, as we previously had it extended all the way, making it harder for people to read.
  • The CI flame are now positioned to the bottom right corner in the "content" box. It made it harder to read, specifically on mobile devices.
  • Making tables responsive again, but with "pre" rendering instead of the default nowrap. Rendering as we see it in .rst, real "enter" in templates results in enter in the userguide itself. Or we will end up with "endless" scrolling in Validation - Available Rules.
  • Fixed incorrect rendering in "Localization".

Checklist:

  • Securely signed commits
  • User guide updated
  • Conforms to style guide

@lonnieezell
Copy link
Member

Looks good. Thanks!

@lonnieezell lonnieezell merged commit 34d6338 into codeigniter4:develop Apr 20, 2020
@jreklund jreklund deleted the ug-fixed-width branch April 20, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants