-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MockEmail class #2788
add MockEmail class #2788
Conversation
I've added unit test for |
This looks good. We do need a way to incorporate testing failures, though, too. Not sure what the preferred way here would be, whether it's another method that specifies the result, or another parameter I'm not too concerned. @MGatner thoughts? |
Yes I think this is a great start. I was thinking of something like this:
That way a test could check |
@MGatner I've added |
I realized that |
Thanks @samsonasik this is precisely what I'd hoped for! Glad to see it wasn't too complicated either. |
@samsonasik I'm working on some tweaks to Email testing... Isn't the precisely what we don't want? Setting |
Based on @MGatner comment at #2785 (comment)
Checklist: