Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace legacy CI3 constant. Fixes #2512 #2523

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Jan 30, 2020

Description
The Email class was ported from CI3 and still contains a legacy constant, which will cause errors in CI4. This PR replaces the constant with its intended definition.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner MGatner merged commit 6bdf787 into codeigniter4:develop Jan 31, 2020
@MGatner MGatner deleted the iconv branch November 8, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant