Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Guide: Query Builder selectCount - error correction in example #2449

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

jlamim
Copy link
Contributor

@jlamim jlamim commented Dec 10, 2019

Description
In the User Guide there was an error in the code example related to the selectCount() method, where the method called was selectSum().

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Dec 10, 2019

Good catch! We need PRs signed though, unless the admins want to override. A cool tip, for non-code related PRs you can prefix the commit (not the PR, the actual commit) with "[ci skip]" to prevent the testing pipelines from running.

@lonnieezell lonnieezell merged commit 2887cac into codeigniter4:develop Dec 10, 2019
@jlamim
Copy link
Contributor Author

jlamim commented Dec 12, 2019

Thanks for the info @MGatner . I'mm reading all the documentation as I'm working on a new book on CodeIgniter 4 which I intend to release as soon as we have the official release for production use. So in this process, whenever I find something to be adjusted in the official documentation or additional content that can further contribute to the documentation, I will make my contribution.

@MGatner
Copy link
Member

MGatner commented Dec 12, 2019

@jlamim That's awesome! Be sure to share info about your book on the forums when it is available. And thanks for the contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants