Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in url_title() function with diacritics #2325

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Fix bug in url_title() function with diacritics #2325

merged 1 commit into from
Oct 11, 2019

Conversation

michalsn
Copy link
Member

Description
This PR fixes the problem with lowercasing the diacritics.
Ref: #2323

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

jim-parry
jim-parry approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@jim-parry jim-parry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MGatner MGatner merged commit acdeaf9 into codeigniter4:develop Oct 11, 2019
@MGatner MGatner mentioned this pull request Oct 11, 2019
Closed
@michalsn michalsn deleted the feature/url_title_fix branch May 4, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-parry jim-parry jim-parry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalsn @jim-parry @MGatner