Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUICKFIX Batch Update Where Reset #2252

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

rayliverified
Copy link
Contributor

@rayliverified rayliverified commented Sep 21, 2019

Description
*FIX Batch Update WHERE condition behaves inconsistently due to WHERE being cleared after the first batch. Save and restore WHERE conditions for each batch.

This fixes an issued raised 8 years ago here: https://stackoverflow.com/a/58043102/6211703

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Sep 24, 2019

Your signed commit succeeded but git revert is not git reset so the previous commits are still there. These steps should fix it but you may need to adjust:

git reset HEAD~3
git add .
git commit -m "QUICKFIX Batch Update Where Reset"
git status

Then if all looks good, git push

@rayliverified
Copy link
Contributor Author

Thanks for taking a look. I've updated the branch with the signed commit.

@MGatner
Copy link
Member

MGatner commented Sep 27, 2019

Looks good, thanks for that update.

@MGatner MGatner merged commit fd1e93b into codeigniter4:develop Sep 27, 2019
@rayliverified rayliverified deleted the ray-batchupdatefix branch September 27, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants