Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter listTables cache response on constrainPrefix #2213

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Filter listTables cache response on constrainPrefix #2213

merged 1 commit into from
Sep 17, 2019

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 11, 2019

Description
Currently if the database datacache has a copy of the tables it will return the whole set regardless of $constrainPrefix. This change checks for $constrainPrefix and filters the returned array accordingly.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 4684036 into codeigniter4:develop Sep 17, 2019
@MGatner MGatner deleted the list-tables-cached branch September 17, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MGatner @lonnieezell