Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration rollback reverse #2191

Merged

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Sep 5, 2019

Description
Per: #2147 (comment)

Migration rollbacks are currently rolling back batch-by-batch in the correct order, but within the batch migrations are being downgrading in ascending order. This reverses the migrations within a batch so they are downgraded appropriately.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 3768431 into codeigniter4:develop Sep 5, 2019
@MGatner MGatner deleted the migration-rollback-reverse branch September 5, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants