Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix store() default value bug #2123

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Conversation

s-proj
Copy link
Contributor

@s-proj s-proj commented Aug 10, 2019

fix store() default value creation'index. html'file path error,like '20190810index.html'

Each pull request should address a single issue, and have a meaningful title.

Description
Explain what you have changed, and why.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

---------Remove from here down in your description----------

Notes

  • Pull requests must be in English
  • If the PR solves an issue, reference it with a suitable verb and the issue number
    (e.g. fixes 12345
  • Unsolicited PRs will be considered, but there is no guarantee of acceptance
  • Pull requests should be from a feature branch in the contributor's fork of the repository
    to the develop branch of the project repository

fix store() default value creation'index. html'file path error,like '20190810index.html'
@lonnieezell
Copy link
Member

This caused a problem with existing tests, and looks like file naming elsewhere was thrown off because of it. See https://travis-ci.org/codeigniter4/CodeIgniter4/jobs/570127900

system/HTTP/Files/UploadedFile.php Outdated Show resolved Hide resolved
@jim-parry jim-parry changed the title fix store() default value bug WIP fix store() default value bug Sep 17, 2019
@jim-parry
Copy link
Contributor

I checked the user guide, and getErrorMessage is actually not mentioned on the validation page. It is an internal method.
I think we are good to go with this PR.

@MGatner
Copy link
Member

MGatner commented Oct 17, 2019

Looks good to me! Coveralls has been weird - I don't know enough about how it does the count, but it seems like these days any PR that touches a file without adding tests will count as a decrease.

@lonnieezell lonnieezell merged commit baaefe7 into codeigniter4:develop Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants