Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct user to follow the upgrade steps after installation #2015

Merged
merged 1 commit into from
May 18, 2019
Merged

Direct user to follow the upgrade steps after installation #2015

merged 1 commit into from
May 18, 2019

Conversation

agmckee
Copy link
Contributor

@agmckee agmckee commented May 18, 2019

As discussed on the community forums, the appstarter doesn't work out of the box after a fresh installation. This was determined to be due to the composer.lock file being out of date, running composer update installs the up to date version of the framework.

Description
Updated the installation via Composer documentation to direct users to follow the steps in the "Upgrading" section even after a fresh installation. This ensures the framework is up to date.

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs: N/A
  • Unit testing, with >80% coverage: N/A
  • User guide updated
  • Conforms to style guide: N/A

@jim-parry
Copy link
Contributor

Oooh - you may have hit the nail on the head ... the appstarter ships with a composer.lock file that it shouldn't! Let me play with that ... this PR might not be needed if the problem can be fixed at the root :)

@jim-parry
Copy link
Contributor

composer.lock is git ignored, and I don't know how it got into the repo :(
I have deleted it, and re-created the beta.3 release, but it still shows up with alpha.4 and needs updating :(
I am going to leave your comment in the installation instructions, and try to figure out this puzzle later.
Thanks!

@jim-parry jim-parry merged commit b71a4c7 into codeigniter4:develop May 18, 2019
@MGatner
Copy link
Member

MGatner commented May 20, 2019

@jim-parry Sorry if this is a dumb question, but did you remove the file or clean it from the history? .gitignore has weird interactions with files already committed and git rm.

@jim-parry
Copy link
Contributor

Good question. I probably didn't do it right, and need to fix it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants