Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses csrf_field and form_hidden instead of inline-html in form_open #1633

Merged
merged 9 commits into from
Jan 2, 2019

Conversation

nowackipawel
Copy link
Contributor

Allows to pass the ID of CSRF field as a key of form_open $attribute arr.
form_open(['csrf_id' => 'id-foo-bar']);

Uses csrf_field for generating CSRF field.
Uses form_hidden instead of inline-html in form_open.

Copy link
Member

@lonnieezell lonnieezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this - but it needs documentation added.

system/Helpers/form_helper.php Outdated Show resolved Hide resolved
@jim-parry
Copy link
Contributor

@lonnieezell The doc change looks good to me.

@lonnieezell lonnieezell merged commit 0fba13c into codeigniter4:develop Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants