-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unneeded try {} catch {} on @fopen at Cache FileHandler::writeFile() #1525
remove unneeded try {} catch {} on @fopen at Cache FileHandler::writeFile() #1525
Conversation
I had issues because fopen is suppressed and the catch just returned false. Testing the Cache Files, some tests return false but is not possible know why if the cache directory has not write permission. Nothing is logged too. Maybe a note on user_guide about this is important. |
Also, the directories inside |
how about check with |
I see two options at the moment:
|
I like both the last suggestions from natanfelles. |
c1da31c
to
1fe3de0
Compare
I've added note in userguide for use 777 to make path writable and use |
I've added unit test for check against |
By providing
@
in front offopen()
will make it always return false on failure fopen, so the catch was never reached,try {} catch {}
is not needed.Checklist: