Release prep part 1 #1248
Merged
Release prep part 1 #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jim-parry
commented
Sep 27, 2018
jim-parry
commented
- standardize "todo" tags in source
- remove unneeded autodoc.php
- remember composer update in admin/release
- first crack at upgrading 3.x to 4.x guide
lonnieezell
reviewed
Sep 27, 2018
| - There is also a `writable` folder, to hold cache data, logs, and session data | ||
| - The `application` folder looks very similar to that for CI3, with some | ||
| name changes (eg Filters instead of hooks) and capitalization, and some subfolders |
There was a problem hiding this comment.
Events replaced Hooks, not filters.
There was a problem hiding this comment.
I will stick to mentioning changed names :-/
| **Controllers** | ||
| - Controllers extend \CodeIgniter\Controller instead of CI_Controller | ||
| - They don't use a constructor any more (to invoke CI "magic"); they |
There was a problem hiding this comment.
I wouldn't mention initController. That is used behind the scenes to free up the constructor, but the user's don't need to know about it. The ones that know about it so far are just confused by it :)
There was a problem hiding this comment.
Will adjust wording
| **Views** | ||
| - Your views look much like before, but they are invoked differently ... | ||
| instead of CI3's `$this->load->view(x);` you can use `view(x);` |
There was a problem hiding this comment.
You'll need to do echo view() not just view()
lonnieezell
reviewed
Sep 27, 2018
| - They don't use a constructor any more (to invoke CI "magic"); they | ||
| instead call `initController` | ||
| - They don't use a constructor any more (to invoke CI "magic") unless | ||
| that is part of a bvase controller you make |
There was a problem hiding this comment.
I'm guessing this was supposed to be base not bvase :)
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.