Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct helper tests namespace #1207

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

jim-parry
Copy link
Contributor

Fix the namespace of the helper unit tests.
Yes, this meant adding some "use" statements, but the namespaces are right :)

@jim-parry
Copy link
Contributor Author

Hmm ... a redis test is failing. Not clear how helper test changes would affect that!

@lonnieezell
Copy link
Member

Your changes wouldn't. I've started a list that currently has 5 or 6 tests that randomly fail that we need to look into, just hasn't made it to the top of my priority list, yet. :)

@lonnieezell lonnieezell merged commit 8a4ff9b into codeigniter4:develop Sep 7, 2018
@jim-parry jim-parry deleted the fix/helpertests branch September 7, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants