refactor: strtolower() should take only string

codeigniter4 · Jan 6, 2022 · c49622f · c49622f
1 parent 2778ce6
commit c49622f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/system/Validation/FormatRules.php b/system/Validation/FormatRules.php
@@ -317,7 +317,8 @@ public function valid_url_strict(?string $str = null, ?string $validSchemes = nu
             return false;
         }
 
-        $scheme       = strtolower(parse_url($str, PHP_URL_SCHEME) ?? ''); // absent scheme gives null
+        // parse_url() may return null and false
+        $scheme       = strtolower((string) parse_url($str, PHP_URL_SCHEME));
         $validSchemes = explode(
             ',',
             strtolower($validSchemes ?? 'http,https')