Skip to content

Commit

Permalink
Merge pull request #1451 from samsonasik/remove-unused-session-start-…
Browse files Browse the repository at this point in the history
…check-at-ensure-session

remove unneeded $session->start(); check on RedirectResponse::ensureSession()
  • Loading branch information
jim-parry authored Nov 11, 2018
2 parents 38bebf6 + e84bc2c commit 998b020
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions system/HTTP/RedirectResponse.php
Original file line number Diff line number Diff line change
Expand Up @@ -163,17 +163,6 @@ public function with(string $key, $message)
*/
protected function ensureSession()
{
$session = Services::session();

// Ensure we have the session started up.
// true for travis-ci, so not coverable
// @codeCoverageIgnoreStart
if ( ! isset($_SESSION))
{
$session->start();
}
// @codeCoverageIgnoreEnd

return $session;
return Services::session();
}
}

0 comments on commit 998b020

Please sign in to comment.