Merge pull request #5651 from iRedds/feature/command-routes-closure

Feature: "spark routes" command shows routes with closure.
codeigniter4 · Feb 5, 2022 · 1c455b5 · 1c455b5
2 parents ec146df + 54438e3
commit 1c455b5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/system/Commands/Utilities/Routes.php b/system/Commands/Utilities/Routes.php
@@ -11,6 +11,7 @@
 
 namespace CodeIgniter\Commands\Utilities;
 
+use Closure;
 use CodeIgniter\CLI\BaseCommand;
 use CodeIgniter\CLI\CLI;
 use CodeIgniter\Commands\Utilities\Routes\AutoRouteCollector;
@@ -92,11 +93,11 @@ public function run(array $params)
 
             foreach ($routes as $route => $handler) {
                 // filter for strings, as callbacks aren't displayable
-                if (is_string($handler)) {
+                if (is_string($handler) || $handler instanceof Closure) {
                     $tbody[] = [
                         strtoupper($method),
                         $route,
-                        $handler,
+                        is_string($handler) ? $handler : '(Closure)',
                     ];
                 }
             }

diff --git a/tests/_support/Config/Routes.php b/tests/_support/Config/Routes.php
@@ -13,3 +13,4 @@
 
 // This is a simple file to include for testing the RouteCollection class.
 $routes->add('testing', 'TestController::index', ['as' => 'testing-index']);
+$routes->get('closure', static fn () => 'closure test');
diff --git a/tests/system/Commands/CommandTest.php b/tests/system/Commands/CommandTest.php
@@ -110,6 +110,7 @@ public function testRoutesCommand()
     {
         command('routes');
 
+        $this->assertStringContainsString('| (Closure)', $this->getBuffer());
         $this->assertStringContainsString('| Route', $this->getBuffer());
         $this->assertStringContainsString('| testing', $this->getBuffer());
         $this->assertStringContainsString('\\TestController::index', $this->getBuffer());
Original file line number	Diff line number	Diff line change
Expand Up		@@ -13,3 +13,4 @@

		// This is a simple file to include for testing the RouteCollection class.
		$routes->add('testing', 'TestController::index', ['as' => 'testing-index']);
		$routes->get('closure', static fn () => 'closure test');