refacotr: update the exception style.

Signed-off-by: ytetsuro <phper.0o0@gmail.com>
codeigniter4 · Oct 4, 2018 · 0dc623b · 0dc623b
1 parent df83c7e
commit 0dc623b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/system/HTTP/DownloadResponse.php b/system/HTTP/DownloadResponse.php
@@ -36,8 +36,7 @@
  * @filesource
  */
 use CodeIgniter\HTTP\Exceptions\HTTPException;
-use BadMethodCallException;
-use LogicException;
+use CodeIgniter\Exceptions\DownloadException;
 use CodeIgniter\Files\File;
 use Config\Mimes;
 
@@ -107,7 +106,7 @@ public function setBinary(string $binary)
 	{
 		if ($this->file !== null)
 		{
-			throw new BadMethodCallException('When setting filepath can not set binary.');
+			throw DownloadException::forCannotSetBinary();
 		}
 
 		$this->binary = $binary;
@@ -122,7 +121,7 @@ public function setFilePath(string $filepath)
 	{
 		if ($this->binary !== null)
 		{
-			throw new BadMethodCallException('When setting binary can not set filepath.');
+			throw DownloadException::forCannotSetFilePath($filepath);
 		}
 
 		$this->file = new File($filepath, true);
@@ -368,8 +367,7 @@ public function noCache(): self
 	 */
 	public function setCache(array $options = [])
 	{
-		// @todo: Should I make exceptions?
-		throw new BadMethodCallException('It does not supported caching for downloading.');
+		throw DownloadException::forCannotSetCache();
 	}
 
 	//--------------------------------------------------------------------
@@ -489,7 +487,7 @@ public function sendBody()
 			return $this->sendBodyByFilePath();
 		}
 
-		throw new LogicException('Not found download body source.');
+		throw DownloadException::forNotFoundDownloadSource();
 	}
 
 	/**

diff --git a/tests/system/HTTP/DownloadResponseTest.php b/tests/system/HTTP/DownloadResponseTest.php
@@ -4,9 +4,7 @@
 use CodeIgniter\Files\Exceptions\FileNotFoundException;
 use DateTime;
 use DateTimeZone;
-use BadMethodCallException;
-use InvalidArgumentException;
-use LogicException;
+use CodeIgniter\Exceptions\DownloadException;
 
 class DownloadResponseTest extends \CIUnitTestCase
 {
@@ -119,15 +117,15 @@ public function testCantSetCache()
 	{
 		$response = new DownloadResponse('unit-test.txt', true);
 
-		$this->expectException(BadMethodCallException::class);
+		$this->expectException(DownloadException::class);
 		$response->setCache();
 	}
 
 	public function testWhenFilepathIsSetBinaryCanNotBeSet()
 	{
 		$response = new DownloadResponse('unit-test.txt', true);
 
-		$this->expectException(BadMethodCallException::class);
+		$this->expectException(DownloadException::class);
 		$response->setFilePath(__FILE__);
 		$response->setBinary('test');
 	}
@@ -136,7 +134,7 @@ public function testWhenBinaryIsSetFilepathCanNotBeSet()
 	{
 		$response = new DownloadResponse('unit-test.txt', true);
 
-		$this->expectException(BadMethodCallException::class);
+		$this->expectException(DownloadException::class);
 		$response->setBinary('test');
 		$response->setFilePath(__FILE__);
 	}
@@ -248,7 +246,7 @@ public function testThrowExceptionWhenNoSetDownloadSource()
 	{
 		$response = new DownloadResponse('unit-test.php', false);
 
-		$this->expectException(LogicException::class);
+		$this->expectException(DownloadException::class);
 		$response->sendBody();
 	}
 }