-
Notifications
You must be signed in to change notification settings - Fork 61
Fixed ConcurrentModificationException on a map and tweeked some options. #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: mmazas <mmazas@ITEM-S104678.emea.msad.sopra>
Signed-off-by: mmazas <mmazas@ITEM-S104678.emea.msad.sopra>
Do you have a stack trace of the ConcurrentModificationException? |
I had one, but did not record it, pointing on the second call to it.next(),
denoting the map change due to the put() on it; the proposed and tested fix
is to use an additional map ca2.
Le sam. 12 juil. 2025 à 11:17, Olivier Lamy ***@***.***> a
écrit :
… *olamy* left a comment (codehaus-plexus/plexus-compiler#443)
<#443 (comment)>
Do you have a stack trace of the ConcurrentModificationException?
—
Reply to this email directly, view it on GitHub
<#443 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFQZRCZPKINQOZYDFJBRWVT3IDHBLAVCNFSM6AAAAACBDR3KUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANRUHE4DANBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: mmazas <mmazas@ITEM-S104678.emea.msad.sopra>
I added a commit to fix erroneous excludes management. |
@@ -759,7 +781,7 @@ protected static Set<String> getSourceFilesForSourceRoot(CompilerConfiguration c | |||
|
|||
if (excludes != null && !excludes.isEmpty()) { | |||
String[] exclStrs = excludes.toArray(new String[excludes.size()]); | |||
scanner.setIncludes(exclStrs); | |||
scanner.setExcludes(exclStrs); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do too but did not find a way to create a second pull request while the first one was still opened...
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
You should get one easily with:
|
No description provided.