Path.relativize() may throw exception if source and build directories…

… are on different Windows drives Closes #364
codehaus-plexus · Feb 23, 2024 · 57dfc26 · 57dfc26
1 parent 2248255
commit 57dfc26
Showing 1 changed file with 19 additions and 7 deletions.
diff --git a/plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/AbstractCompiler.java b/plexus-compiler-api/src/main/java/org/codehaus/plexus/compiler/AbstractCompiler.java
@@ -268,19 +268,31 @@ private static String getCanonicalPath(File origFile) throws CompilerException {
 
     protected void logCompiling(String[] sourceFiles, CompilerConfiguration config) {
         if (log.isInfoEnabled()) {
-            String to = (config.getWorkingDirectory() == null)
-                    ? config.getOutputLocation()
-                    : config.getWorkingDirectory()
-                            .toPath()
-                            .relativize(new File(config.getOutputLocation()).toPath())
-                            .toString();
             log.info("Compiling "
                     + (sourceFiles == null
                             ? ""
                             : (sourceFiles.length + " source file" + (sourceFiles.length == 1 ? " " : "s ")))
                     + "with "
                     + getCompilerId() + " [" + config.describe() + "]" + " to "
-                    + to);
+                    + getRelativeWorkingDirectory(config));
         }
     }
+
+    private static String getRelativeWorkingDirectory(CompilerConfiguration config) {
+        String to;
+        if (config.getWorkingDirectory() == null) {
+            to = config.getOutputLocation();
+        } else {
+            try {
+                to = config.getWorkingDirectory()
+                        .toPath()
+                        .relativize(new File(config.getOutputLocation()).toPath())
+                        .toString();
+            } catch (IllegalArgumentException e) {
+                // may happen on Windows if the working directory is on a different drive
+                to = config.getOutputLocation();
+            }
+        }
+        return to;
+    }
 }