Issues 57/design new admin page questionnaire #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMStudiosJoe
reviewed
Aug 3, 2021
| @@ -13,7 +13,7 @@ router.route('/').get((req, res) => { | |||
|
|
|||
| router.route('/:title.:language').get((req, res) => { | |||
| Questionnaires.findOne({ | |||
| title: req.params.title, | |||
| title: decodeURIComponent(req.params.title), | |||
There was a problem hiding this comment.
why is this needed here?
There was a problem hiding this comment.
in case the title has any special characters or spaces
JMStudiosJoe
reviewed
Aug 3, 2021
| <Navbar content={content} dashboard={true} /> | ||
| <section> | ||
| {chooseFile ? ( | ||
| <form> |
There was a problem hiding this comment.
yes correct use of form thank you!
JMStudiosJoe
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
fantastic work @mrgjune thank you very much! just a couple of comments before we merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Describe the general shape of this PR (new feature? refactor? bug fix? one-line change?)
new features
Describe what changes are being made
Describe why these changes are being made
Allow the app to have multiple questionnaires and give admin control of updating questionnaires
Describe how you tested these changes
functional tests
Link to relevant external documentation
📋 Mandatory Checklist
Example of a checked item (please remove when creating your Pull Request)
Linked to the Github Issues being addressed using the right sidebar ➡️
Have you discussed these changes with the project leader(s)?
Do all variable and function names communicate what they do?
Were all the changes commented and / or documented?
Is the PR the right size? (If the PR is too large to review, it might be good to break it up into multiple PRs.)
Does all work in progress, temporary, or debugger code have a TODO comment with links to Github issues?
If you changed the user interface, did you add before and after screenshots to below?
🖼️ Screenshots and Screen Recordings
Before
After
📘 Glossary