Fix/breadcrumb browse #2499
Merged
Fix/breadcrumb browse #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
sebjulliand
added
the
bug
|
👋 A new build is available for this PR based on 7299a1b. |
chrjorgensen
approved these changes
Feb 1, 2025
|
Much obliged @chrjorgensen 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes the breadcrumbs navigation for members.
The call to
getMemberAttributesmade bystatwould fail for physical files, preventing the navigation from working (clicking on it would do nothing).This PR fixes this by preventing stat from getting attributes except for members.
It also fixes the library listing in the breadcrumb (clicking on the library would only show QSYS and then it would fail to list anything relevant). QSYS FS now uses a dedicated call to
OBJECT_STATISTICS, using*ALLSIMPLEsince all we need is a list of names.How to test this PR
Checklist