Correctly check GetNewLibl component state #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
sebjulliand
added
the
bug
|
👋 A new build is available for this PR based on abb7741. |
worksofliam
approved these changes
Jan 7, 2025
|
Brilliant, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GetNewLiblcomponent state was not checked as it should. Instead of being checked in the corresponding component, it was added to theIBMi::remoteAppsglobal array to be checked as a remote feature. This caused two issues:GetNewLiblwas not checkedGetNewLiblwas added to the global array with each 'non-quick connect' connection attemptsThis PR fixes this by:
GetNewLiblas a remote feature anymoreGetNewLiblversion in its component objectHow to test this PR
GetNewLiblprocedure get created in the connection temporary library with the version in its commentChecklist