Re-org command definitions #1724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@worksofliam Seems like we didn't get this one tested and merged in time - so now there are conflicts... 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
instantiate.tsfile needed a serious cleanup. It was getting big. I've refactored most of the commands into groups - either into new files to register the actions, or into existing files where login already exist.Sadly, our automated tests do not cover lots of the user accessible commands, so manual testing (just using the app!) will need to be done.
I can confirm that running Actions still works, and I can still open files, so that's the important stuff.
Any feedback is welcome.
Checklist
console.logs I added