Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/local_improvements_2 #1723

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Feature/local_improvements_2 #1723

merged 11 commits into from
Jan 17, 2024

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Dec 14, 2023

Changes

Features

  • New optional feature to automatically create a branch library when switching/creating a branch
    • Or, if the library already exists when they check out to branch, it will ask if they want to create a filter for it if they do not have one.
  • Variables now appear in actions.json, making it easier to understand the content

Internal changes

Variable expansion was broken. If I had an .env like this before, it would not expand when building the library list. This is now resolved.

CURLIB=&BRANCHLIB

Secondly, we had some type mis-matches for variables. In runAction we were using Map<string, string>, but the RemoteCommand interface is using Record<string, string> (the same as {[key: string]: string})). This was a pain and because changing RemoteCommand risks breaking a lot of APIs (including external extensions using our API) I felt that a reasonable idea to convert Variables to be a Record<string, string>. Sorry @sebjulliand !! But, it does mean variable expansion of variables works in almost every scenario now.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam linked an issue Dec 14, 2023 that may be closed by this pull request
@worksofliam worksofliam mentioned this pull request Dec 14, 2023
@worksofliam worksofliam marked this pull request as ready for review December 14, 2023 04:50
@worksofliam worksofliam requested a review from a team December 14, 2023 04:50
@Wright4i Wright4i self-assigned this Dec 15, 2023
Copy link
Contributor

@Wright4i Wright4i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam see 3 pending code comments. Thanks!

package.json Outdated Show resolved Hide resolved
src/api/local/git.ts Outdated Show resolved Hide resolved
src/api/local/git.ts Outdated Show resolved Hide resolved
@worksofliam
Copy link
Contributor Author

@Wright4i I fixed two of the three issues you raised - thanks for a great review.

Sadly, we need #1741 to be merged into this branch for the fixes to take affect right now. I will re-request a review when that is done.

Copy link
Contributor

@Wright4i Wright4i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look good. Approved

@Wright4i Wright4i removed their assignment Dec 23, 2023
@worksofliam worksofliam requested a review from Wright4i December 24, 2023 01:09
@worksofliam
Copy link
Contributor Author

@Wright4i Requesting your review again! I fixed the issue you described above: we can now detect when a repo is initialized and handle those branch changes too!

Please try again and let me know what you think.

Copy link
Contributor

@Wright4i Wright4i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fix worked and prompted to create a library on a branch switch after creating a new git repo.
image

@worksofliam worksofliam requested a review from Wright4i January 9, 2024 23:54
@worksofliam
Copy link
Contributor Author

@Wright4i Any chance I can bother you to retest this again after a fairly large merge? The same tests as before would be fab. Thank you.

@worksofliam worksofliam removed their assignment Jan 9, 2024
@Wright4i Wright4i self-assigned this Jan 12, 2024
Copy link
Contributor

@Wright4i Wright4i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam No issues with my tests after the merge & typo fix. Code looks solid. Good to go 👍

@Wright4i Wright4i removed their assignment Jan 12, 2024
@worksofliam worksofliam merged commit a2ba223 into master Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optional feature: branch library creation on change
2 participants