-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/local_improvements_2 #1723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@worksofliam see 3 pending code comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look good. Approved
@Wright4i Requesting your review again! I fixed the issue you described above: we can now detect when a repo is initialized and handle those branch changes too! Please try again and let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wright4i Any chance I can bother you to retest this again after a fairly large merge? The same tests as before would be fab. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@worksofliam No issues with my tests after the merge & typo fix. Code looks solid. Good to go 👍
Changes
Features
actions.json
, making it easier to understand the contentInternal changes
Variable expansion was broken. If I had an
.env
like this before, it would not expand when building the library list. This is now resolved.CURLIB=&BRANCHLIB
Secondly, we had some type mis-matches for variables. In
runAction
we were usingMap<string, string>
, but theRemoteCommand
interface is usingRecord<string, string>
(the same as{[key: string]: string})
). This was a pain and because changingRemoteCommand
risks breaking a lot of APIs (including external extensions using our API) I felt that a reasonable idea to convertVariables
to be aRecord<string, string>
. Sorry @sebjulliand !! But, it does mean variable expansion of variables works in almost every scenario now.Checklist
console.log
s I added