Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASP support member lookup #1706

Merged
merged 5 commits into from
Dec 13, 2023
Merged

ASP support member lookup #1706

merged 5 commits into from
Dec 13, 2023

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Dec 11, 2023 •
edited
Loading

Changes

Similar to opening files, memberResolve will now look in the user defined ASP to find a member. Additionally, the API can accept an ASP and will use that instead.

Also solves a bug with the qualifyPath which wasn't handling QSYS correctly.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam linked an issue Dec 11, 2023 that may be closed by this pull request
resolveMember to consider ASP #1684
Closed
@worksofliam worksofliam added this to the 2.6.0 milestone Dec 11, 2023
worksofliam
worksofliam commented Dec 13, 2023
View reviewed changes
src/api/IBMiContent.ts Outdated
return `/QSYS.LIB/${file.library}.LIB/${file.name}.FILE/${member}.MBR`;
}
})
.map(file => Tools.escapePath(file))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrjorgensen Is this the valid way to use escape path? The tests continue to pass and this should ensure that $ can be used in the path itself.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam LGTM - even though I haven't had anything to do with Tools.escapePath... you may be thinking of Tools.sanitizeLibraryNames?

Using Tools.escapePath should be okay, when the library is not preceded by a space (which caused trouble in the shell when the library name started with #).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supposed I better use Tools.sanitizeLibraryNames too!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrjorgensen I actually used both in a new commit. Made a well needed improved to one of our existing APIs.

@worksofliam worksofliam linked an issue Dec 13, 2023 that may be closed by this pull request
Copies with non-latin characters #1617
Closed
@worksofliam
Copy link
Contributor Author

Tests continue to pass.

@worksofliam worksofliam merged commit 745325a into master Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

resolveMember to consider ASP Copies with non-latin characters
2 participants
@worksofliam @chrjorgensen