Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

52 with status fix #267

Merged
merged 8 commits into from
Dec 1, 2019
Merged

52 with status fix #267

merged 8 commits into from
Dec 1, 2019

Conversation

ethoreson
Copy link
Collaborator

#52

@ethoreson ethoreson requested a review from divlogic November 30, 2019 02:28
divlogic
divlogic requested changes Dec 1, 2019
View reviewed changes
Copy link
Collaborator

@divlogic divlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like when you update the color and save it, the request sends a lowercase hex code and the api isn't accepting it.

@ethoreson
Copy link
Collaborator Author

It looks like when you update the color and save it, the request sends a lowercase hex code and the api isn't accepting it.

@divlogic thank you! that must be the source of the "8-0" bug. On it!

@ethoreson ethoreson merged commit f679feb into master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divlogic divlogic divlogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethoreson @divlogic