Allow users to specify number of crime incidents #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it takes second argument: number_incidents
this file is downloaded from alexa
jmartini
requested changes
Sep 2, 2019
| } | ||
| ], | ||
| "samples": [ | ||
| "most recent {number_incidents} crime activity", | ||
| "top {number_incidents} incidents happened near me", | ||
| "top {number_incidents} crime activity", |
There was a problem hiding this comment.
Let's add some more options here. This are things I tried when testing the skill before looking at this list, but try to brainstorm as many as you can:
- what are the four most recent crime reports (goes to 311 requests intent)
- give me two crime reports (this gave me the default number of reports)
- what two crimes were reported (failed to find intent)
In addition, I don't think we shouldn't use "top" since that implies some sort of ranking. The only way we currently sort is by most recent reported date.
also replace "top" with "most recent"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix issue #185 commits include