Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change submission status checking to handle out of order xml #5499

Conversation

mrotondo
Copy link
Contributor

@mrotondo mrotondo commented Jan 31, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • This year, we've seen MeF submissions-status API responses that include "out of order" submissions statuses for a few states. That is, the XML document we receive includes "Received by State" after "Acknowledgement Received from State". Because we were previously assuming that we would always see the most "recent" or furthest-progress status at the top of the list, we were only looking at first node in the XML document corresponding to each submission ID we poll for. Thus, we have been failing to process a bunch of submissions out of the transmitted state.
  • This PR changes our submission status checking to look through the whole list of submission statuses for each submission ID we are polling for, first looking for any status that would transition the submission to ready-for-ack, then any which would keep it in transmitted (and then failing if neither are found, though we should always find the node that marked the submission as transmitted in the first place).

How to test?

  • There are submissions on demo that are stuck in this state, so we can do acceptance by checking to see whether they proceed to :ready-for-ack and :accepted after this is merged to main and the cron job runs the poll service.

Copy link

Heroku app: https://gyr-review-app-5499-bb2a2869ffbe.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5499 (optionally add --tail)

Copy link
Contributor

@embarnard embarnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mrotondo mrotondo merged commit 903f7d4 into main Jan 31, 2025
7 checks passed
@mrotondo mrotondo deleted the FYST-1733-id-nc-handle-out-of-order-statuses-in-the-me-f-api-response branch January 31, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants