change submission status checking to handle out of order xml #5499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
submissions-status
API responses that include "out of order" submissions statuses for a few states. That is, the XML document we receive includes "Received by State" after "Acknowledgement Received from State". Because we were previously assuming that we would always see the most "recent" or furthest-progress status at the top of the list, we were only looking at first node in the XML document corresponding to each submission ID we poll for. Thus, we have been failing to process a bunch of submissions out of thetransmitted
state.ready-for-ack
, then any which would keep it intransmitted
(and then failing if neither are found, though we should always find the node that marked the submission astransmitted
in the first place).How to test?
:ready-for-ack
and:accepted
after this is merged to main and the cron job runs the poll service.