Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1741 Completely undo deduction method based suppression on MD 502CR XML / PDF #5498

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Jan 31, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit tests
    • Test data used: Katie_HOH
    • should ensure xml/pdf still load with values for all fields on MD502CR for nonstandard deduction submission
    • the submission needs to be tested on demo

Screenshots (for visual changes)

Screenshot 2025-01-31 at 12 04 12 PM Screenshot 2025-01-31 at 12 04 15 PM

Copy link

Heroku app: https://gyr-review-app-5498-7997a4d75bd9.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5498 (optionally add --tail)

@arinchoi03 arinchoi03 merged commit b68da51 into main Feb 3, 2025
7 checks passed
@arinchoi03 arinchoi03 deleted the FYST-1741-undo-502-cr-suppression branch February 3, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants